apache / datasketches-java

A software library of stochastic streaming algorithms, a.k.a. sketches.

Home Page:https://datasketches.apache.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

quotient filter builder bucket suggestion change

c-dickens opened this issue · comments

The Quotient filter number of slots suggestion function currently hardcodes the load factor for the lgNumSlots suggestion. When we decide whether to pass the LOAD_FACTOR constant as a parameter to the filter, we also need to appropriately update the suggestion functions.

Alternatively, we could add a further parameter to suggestLgNumSlots(long maxDistinctItems) to change it to suggestLgNumSlots(long maxDistinctItems, double maxLoad) along with the change
byte result = (byte) Math.ceil(Math.log(maxDistinctItems / maxLoad) / Math.log(2));

Resolved in #584