apache / datasketches-java

A software library of stochastic streaming algorithms, a.k.a. sketches.

Home Page:https://datasketches.apache.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test Smell: It is not a good test practice to introduce nondeterministic randomness in test code

TestSmell opened this issue · comments

Hi!

We notice that the random number generator (RNG) is used to produce test code in your project.
For example, a random generator in the test method named ''checkKomologorovSmirnovStatistic1() '' in ''KolmogorovSmirnovTest.java''
截屏2022-08-17 下午7 04 14

But generating random data in test code is not a good test practice. Since Using nondeterministic randomized data may lead to unexpected unit test failure and once the test case fails, it is hard to trace what test data causes it.

Solution:
There are two solutions:
set a random seed number for your random generator
using a hash method to generate random data

I agree. Will fix.

Done.