Backward compatibility for empty sketches generated from older versions

Question

Backward compatibility for empty sketches generated from older versions

a2l007 opened this issue 5 years ago · comments

The latest version of sketches doesn't seem to be backward compatible for empty sketches generated using older versions. For example in an union operation, using an empty sketch such as AQMDAAAazJM= generated using the older versions would throw the error:

java.lang.AssertionError: reqOffset: 8, reqLength: 8, (reqOff + reqLen): 16, allocSize: 8

    at com.yahoo.memory.UnsafeUtil.assertBounds(UnsafeUtil.java:167)
    at com.yahoo.memory.BaseState.assertValidAndBoundsForRead(BaseState.java:330)
    at com.yahoo.memory.BaseWritableMemoryImpl.getNativeOrderedLong(BaseWritableMemoryImpl.java:284)
    at com.yahoo.memory.WritableMemoryImpl.getLong(WritableMemoryImpl.java:133)
    at com.yahoo.sketches.theta.UnionImpl.update(UnionImpl.java:278)

@AlexanderSaydakov @leerho This is the same problem that I had discussed with you and I'm logging this issue for tracking purposes.

Lee Rhodes · Answer 1 · Wed Aug 28 2019 03:18:19 GMT+0800 (China Standard Time)

Please specify exactly which version you see this problem. "Latest" will change over time :)

Atul Mohan · Answer 2 · Wed Aug 28 2019 04:31:49 GMT+0800 (China Standard Time)

Sorry, the version on which we're seeing this issue is sketches-core 0.13.4

Lee Rhodes · Answer 3 · Fri Nov 15 2019 08:40:47 GMT+0800 (China Standard Time)

@a2l007 This should be fixed as of apache version 1.1.0 and later. Could you please confirm?

Thanks

Lee Rhodes · Answer 4 · Fri Jan 17 2020 11:25:39 GMT+0800 (China Standard Time)

I assume this has been fixed.