Giters

aotuai / brainframe-cli

🧠🖼️👩🏽‍💻 A CLI that makes installing and managing a BrainFrame server easy!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Should commands that need permissions request permissions before beginning?

apockill opened this issue · comments

commented

brainframe install appears to do this, but brainframe update fails as such:

Downloading docker-compose.yml...
curl --fail --location https://aotu.ai/releases/brainframe/latest
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     7  100     7    0     0     25      0 --:--:-- --:--:-- --:--:--    25
curl -o /usr/local/share/brainframe/docker-compose.yml --fail --location https://aotu.ai/releases/brainframe/v0.25.4/docker-compose.yml
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0Warning: Failed to create the file 
Warning: /usr/local/share/brainframe/docker-compose.yml: Permission denied
100  2685  100  2685    0     0  19178      0 --:--:-- --:--:-- --:--:-- 19042
curl: (23) Failed writing body (0 != 2685)

I guess the question is, does brainframe update need permissions, and if so, should it follow the same pattern as brainframe install by checking before starting the process.

commented

Also, a minor question... Is there any way to get the version of the brainframe server without running it? At the moment, I can run brainframe update twice in a row without indication that the process was redundant.