🐛bug: render issue of neo4j schema
nylqd opened this issue · comments
@nylqd t seems to be an issue with the EngineServer component:https://github.com/antvis/G6VP/blob/master/packages/gi-assets-neo4j/src/services/Engine.tsx#L1
https://github.com/antvis/G6VP/blob/master/packages/gi-sdk/src/components/EngineServer/LoadGraph.tsx#L148
because I have switched to the pref/sdk-valtio branch for the upgrade of G6 5.0, which involves a lot of changes, I haven't switched to the master branch to investigate the issue for now. If possible, I would appreciate your help in resolving it.
master
/packages/gi-sdk/src/components/EngineServer/LoadGraph.tsx#L148 because I have switched to the pref/sdk-valtio branch for the upgrade of G6 5.0, which involves a lot of changes, I haven't switched to the master branch to investigate the issue for now. If possible, I would appreciate your help in resolving it.
@pomelo-nwu it seems indeed have bug in getSchemaGraph, i will do some digging around.
![image](https://private-user-images.githubusercontent.com/3632490/284584794-2dabec67-3072-4995-8d3a-71ee560c8eee.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NTkxNjksIm5iZiI6MTcyMDQ1ODg2OSwicGF0aCI6Ii8zNjMyNDkwLzI4NDU4NDc5NC0yZGFiZWM2Ny0zMDcyLTQ5OTUtOGQzYS03MWVlNTYwYzhlZWUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDhUMTcxNDI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTRhYmE3ODk2YmE2NDZmMDA4NTQzN2Y1NmVkMDgzZWNkODQ0NTdlYjY1NDNjODM4ZmU0MmY2NTU4ZGYyYWFhYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.53q-eP_mqbaPyr5wRjNry-MEYUYgimbx0A9pHdJUtqg)
Adjusting the ID retrieval sequence to include source and target node types sounds like a reasonable approach to address the issue stemming from the lack of sourceNodeType
and targetNodeType
in the Neo4j schema information during parsing.
![image](https://private-user-images.githubusercontent.com/3632490/284584892-c557340b-62a2-4530-9999-88d03f374563.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NTkxNjksIm5iZiI6MTcyMDQ1ODg2OSwicGF0aCI6Ii8zNjMyNDkwLzI4NDU4NDg5Mi1jNTU3MzQwYi02MmEyLTQ1MzAtOTk5OS04OGQwM2YzNzQ1NjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDhUMTcxNDI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzcwYThkZTdmNGI0YzFiNTNmZTJkYmU0N2ViNDRlMGRlZWRlOTY4OWVkMzUyYzIxMDU2NzU5ZDJiNzE1YWU4YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.EE70kBYmJGpJZFXTMpjKJMYNn3-0g21Nj9FR4W4wwEs)
An alternative solution is adding sourceNodeType
and targetNodeType
attributes during the parsing of Neo4j schema information seems like a promising approach to address the root cause of the rendering issue.
@pomelo-nwu I'd like some inputs from you to choose one solution over the other