antonybudianto / angular-starter

:star: Gulp Angular Starter using TypeScript (Updated to 4.4.3)

Home Page:https://antonybudianto.github.io/angular-starter/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

the gulp-cssnano changes the z-index of the minified css files

ovione opened this issue · comments

Issue Overview

the gulp-cssnano changes the z-index of the minified css files
Issue Description

this happens when we issue a 'gulp build'

my solution

The solution I found is in the build.js in the task 'build-assets' to add to the 'gulp-cssnano' plugin the following:
cssnano({zindex: false})
that means that the minification will not touch the z-indexes.

I accept the solution. Can you open a pull request for this?
Thank you.

yes I will be glad to do but I'm trying to figure out how to do a PR :)
when I do a 'new pull request' I have a 'Compare changes' screen with the 'create pull request' button disabled.

I have never contributed thats why I'm trying to figure out how to do it.

you can edit the file directly and submit the PR there

I found how.
I forked the project to my github, then I pushed it and I sedt a pull request.
I hope thats correct
cheers
O