antonybudianto / angular-starter

:star: Gulp Angular Starter using TypeScript (Updated to 4.4.3)

Home Page:https://antonybudianto.github.io/angular-starter/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

RC5 breaks "npm run build", errors in tests

jonben opened this issue · comments

Issue Overview

Thanks for this starter kit, everything is working when serving it directly. I'm using the latest version, just got it yesterday. I just have an error when building the app for production.
"npm run build" doesn't work because of errors in src\app\app.component.spec.ts

Issue Description

I tried to fix it, but get stuck at some point.
line 15 : import { TestComponentBuilder } from '@angular/core/testing';
line 52 : const r = new Router(TestComponent, resolver, urlSerializer, outletMap, location, injector, loader, config); < I added the "loader" variable there but I have no clue where it's coming from, which library I should import for it...

did you clone the latest starter?
because I've removed const r = new Router(TestComponent, resolver, urlSerializer, outletMap, location, injector, loader, config);

Ok I just cloned the latest version, mine was from yesterday. ;)

Thanks!

2016-08-12 8:32 GMT+07:00 Antony Budianto notifications@github.com:

Closed #137
#137.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#137 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACM8sFdNr0VXI9A5O0JNbuDt-Bb6lYl1ks5qe80ugaJpZM4JitEk
.

Benoit Schneider
www.eklektik-web.com