Giters

antoniotuzzi / libyuv

Automatically exported from code.google.com/p/libyuv

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

I411ToARGBRow_SSSE3 used but expected AVX2. Adapt from I422ToARGBRow_AVX2

GoogleCodeExporter opened this issue · comments

commented 
Run conversion tests

LIBYUV_FLAGS=-1 LIBYUV_WIDTH=1280 LIBYUV_HEIGHT=720 LIBYUV_REPEAT=1000 perf 
record out/Release/libyuv_unittest --gtest_filter=*ConvertTest*

perf report

Original issue reported on code.google.com by fbarch...@google.com on 26 Jan 2016 at 1:45

commented

Original comment by fbarch...@google.com on 26 Jan 2016 at 1:49

  • Now blocking: #492
commented 
LIBYUV_FLAGS=-1 LIBYUV_WIDTH=1280 LIBYUV_HEIGHT=720 LIBYUV_REPEAT=1000 perf 
record out/Release/libyuv_unittest --gtest_filter=*I411To*RGB*
perf report | grep Row_

    97.07%  libyuv_unittest  libyuv_unittest      [.] I411ToARGBRow_SSSE3
     0.11%  libyuv_unittest  libyuv_unittest      [.] CopyRow_ERMS

Original comment by fbarch...@google.com on 11 Feb 2016 at 12:58

commented 
Was I411ToARGB_Opt (459 ms)
Now I411ToARGB_Opt (324 ms)

95.65%  libyuv_unittest  libyuv_unittest      [.] I411ToARGBRow_AVX2
 0.17%  libyuv_unittest  libyuv_unittest      [.] CopyRow_ERMS

[----------] Global test environment tear-down
[==========] 974 tests from 6 test cases ran. (1608 ms total)
[  PASSED  ] 974 tests.

Original comment by fbarch...@google.com on 11 Feb 2016 at 3:13

commented 
The following revision refers to this bug:
  https://chromium.googlesource.com/libyuv/libyuv.git/+/cc33dc68c7ce7e20e820b5519989ea18a73f5113

commit cc33dc68c7ce7e20e820b5519989ea18a73f5113
Author: Frank Barchard <fbarchard@google.com>
Date: Fri Feb 12 18:26:10 2016

Port I411ToARGBRow to AVX2.

An SSSE3 version already exists, and an AVX2 version is available for
Visual C.  This ports the function to AVX2 completing the AVX2 ports of
all YUV to RGB functions for AVX2 on gcc.

TBR=harryjin@google.com
BUG=libyuv:555

Review URL: https://codereview.chromium.org/1687253002 .

[modify] 
http://crrev.com/cc33dc68c7ce7e20e820b5519989ea18a73f5113/README.chromium
[modify] 
http://crrev.com/cc33dc68c7ce7e20e820b5519989ea18a73f5113/include/libyuv/row.h
[modify] 
http://crrev.com/cc33dc68c7ce7e20e820b5519989ea18a73f5113/include/libyuv/version
.h
[modify] 
http://crrev.com/cc33dc68c7ce7e20e820b5519989ea18a73f5113/source/row_gcc.cc

Original comment by bugdroid1@chromium.org on 12 Feb 2016 at 6:26

commented 
Fixed in r1576

Original comment by fbarch...@google.com on 12 Feb 2016 at 7:27

  • Changed state: Fixed