Problem on vnode attributes from JSX compile
FlorentD opened this issue · comments
Hi all,
I've played with deku last days and I really enjoy it !
However I've seen something strange with the JSX compile,
With a DOM list, the id attribute of vnode created from the node seems to be wrong. It always equals to the size list. This seems to have sad effects on my app.
I suspect babel-plugin-transform-react-jsx
for having bad behavior but not sure... maybe I'm doing wrong.
Here my repo de reproduce the problem : https://github.com/FlorentD/deku-jsx-problem
Thx !
Hey! Thanks for finding this. It looks like this is actually a bug with the way we're caching the result thunks (components). In that array of children, the cached rendered <Card />
s are all the same. The output in the DOM looks right, but what this will do is lead to incorrect diffing on the next pass and we'll end up replacing nodes that we don't need to.
I've added a test for it now and I'm going to track it down.
Ok I've figured this out. I'll have a fixed push up shortly along with a test. 🤔
This is fixed in rc9. Thanks again :)
Thank you !! My app works now like a charm !! :-)