antfu-collective / vitesse

🏕 Opinionated Vite + Vue Starter Template

Home Page:https://vitesse.netlify.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

@antfu/eslint-config does not consider this a TS project

Dimava opened this issue · comments

commented

Describe the bug

@antfu/eslint-config determines that a project is a TS project by checking existence of tsconfig.eslint.ts

So this project is not considered a "ts" project and @typescript-eslint rules are not imported

I don't see this mentioned in Readme so this may be not intended

Reproduction

async function f() {} export function g() { f() } // should error @typescript-eslint/no-floating-promises

System Info

vitest: just cloned

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
commented

Type aware rules are enabled when a tsconfig.eslint.json is found in the project root, which will introduce some stricter rules into your project

So they are not "recommended" ones