antfu-collective / vitesse

🏕 Opinionated Vite + Vue Starter Template

Home Page:https://vitesse.netlify.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

unjs/head@v1.1.0 changed thier schema, resulting in @vueuse/head schema being incorrect and an empty title tag on SSG render

Saganic opened this issue · comments

Describe the bug

unjs/head@v1.10 released a new schema for title definition, that causes vitesse to render an empty title tag with vite SSG.

Reproduction

https://github.com/antfu/vitesse/

System Info

System:
    OS: macOS 12.0.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 12.34 GB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.4.0 - ~/.nvm/versions/node/v18.4.0/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 9.6.1 - ~/.nvm/versions/node/v18.4.0/bin/npm
  Browsers:
    Chrome: 111.0.5563.64
    Firefox: 106.0.5
    Safari: 15.1

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

/cc @harlan-zw can you help check this, and see where could we fix it? Thanks!

Hey @Saganic

Can you provide some details on the issue? Ideally a Stackblitz reproduction.

I've pulled down the Vitesse and ran pnpm build and it looks like the title is generated correctly.

<title>Vitesse</title>

Also, the way you're describing the issue isn't accurate, title schema remains the same within v1.1. No breaking changes were introduced afiak.

Hey @harlan-zw.

Yep, I eagerly created an issue. I think it was an issue with pnpm lock on this commit. Since @antfu update the deps on latest commit, everything appears to work. If you checkout that previous commit, it does indeed still render an empty title tag.