ankitpokhrel / tus-php

🚀 A pure PHP server and client for the tus resumable upload protocol v1.0.0

Home Page:https://tus.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PHP 8 support for V1

paugerhu opened this issue · comments

The V1 cannot be installed via composer on PHP 8, because the PHP 7 is required in composer.json.
Is it possible to add PHP 8 to the composer.json for V1?

commented

@paugerhu you need to upgrade to v2 if you want to use PHP8. Is there any specific reason that you want to use v1 with PHP8?

I use TUS in a Drupal project which is based on Symfony 4, so I can not use Symfony 5 which is a requirement for the V2. After the Dupal 10 has been released, I will be able to upgrade to TUS v2. I am currently ignoring platform requirement in composer to install TUS v1 l, but it is not the best solution.

commented

Apologies for late response!

Symfony 5 requires PHP7.2 and tus-php v1 supports PHP7.1. So for compatibility reasons version was bumped.

I think for your case, you can maintain a fork with changes required for Symfony 5 support on V1. You can get an idea of the changes here v1.3.1...v2.0.0

Let me know if that works for you!

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

Closing because of inactivity.