Problem with the eraser tab
Akshittuli opened this issue · comments
Reproduction Steps
- Click on whiteboard tab while reviewing flashcards and use the feature to write/draw anything
- Click on the erase tab till you have undone the drawing and the erase tab grays out
- Redraw anything by clicking on the whiteboard icon
Expected Result
Upon redrawing, the eraser tab should revert its color from gray to white
Actual Result
On redrawing, the eraser tab still remains grayed out.
Debug info
Refer to the [support page]AnkiDroid Version = 2.10beta3
Android Version = 10
ACRA UUID = bbdbcff5-0c68-4fd5-8b77-95df0b7fc4b3
Research
Enter an [ x ] character to confirm the points below:
[ x ] I have read the support page and am reporting a bug or enhancement request specific to AnkiDroid
[ X ] I have checked the manual and the FAQ and could not find a solution to my issue
[ ] I have searched for similar existing issues here and on the user forum
Hi @Akshittuli,
Thanks for the report! Reproduced in 2.10alpha73
Works on 2.9.7
Will look into it today.
This has got to be due to the disable-icons-while-async-task-is-running PR a couple weeks back. I had a pending item to put a slight delay on disabling the icons as well since they'll flicker now in the normal use case, but it's still useful to have double-click protection and disable them visually for long-running operations (or slow devices in combo with big collections) so the async task doesn't go off on a different card than expected.
Looks like it was my ActionItem change for the flags. 7c9911b works fine.
That was the one I was thinking of - I was a bit iffy on it when it went in but it seemed like it would redraw and if enabled was the default... a revert is clean enough though and it can go in the 2.10beta4 pile for release - can you PR a revert on that one 🙏 ?