Make Install and Build step run a PR check

Question

Make Install and Build step run a PR check

isabelcosta opened this issue 3 years ago · comments

Description

As a reviewer/contributor/admin,
I need new PR check to make sure the app is building successfully,
so that I can merge PR with confidence that the code is not breaking the app.

Mocks

Here's an example of this check for every commit: https://github.com/anitab-org/anitab-org.github.io/runs/3175046196

Acceptance Criteria

Update [Required]

New pull request check for every new pull request created
Run tests on every new pull request created

Definition of Done

All of the required items are completed.
Approval by 1 mentor.

Estimation

1 hour

Raffaele · Answer 1 · Sat Oct 09 2021 05:30:58 GMT+0800 (China Standard Time)

Hi @isabelcosta can I work on this for the hacktoberfest?

Isabel Costa · Answer 2 · Sat Oct 09 2021 05:41:31 GMT+0800 (China Standard Time)

@raffaelecalza of course! I will assign it to you!

Raffaele · Answer 3 · Sat Oct 09 2021 05:42:56 GMT+0800 (China Standard Time)

@raffaelecalza of course! I will assign it to you!

Thanks, tomorrow I'll work on it

Isabel Costa · Answer 4 · Sat Oct 09 2021 05:44:25 GMT+0800 (China Standard Time)

Sure! Just make sure to leave updates here :)

Raffaele · Answer 5 · Sat Oct 09 2021 16:10:35 GMT+0800 (China Standard Time)

Hey @isabelcosta I opened a new PR. I tested the workflow inside my repo and it runs as expected. Let me know if I have to change something or if it's okay