angular-extensions / svg-icons-builder

Angular builder to build svg-icons using svg-to-ts

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Extend schema.json

kreuzerk opened this issue ยท comments

commented

Adjust schema.json to contain options for all conversionTypes (constants, objects, files).

commented

I am not yet sure if we should add one builder that then internally differentiates between the 3 conversionTypes or if we should add three builders. One for constants, one for objects and one for files. Having three builders would have the advantage that we do not mix the options and each builder would have a clear schema.json.

@kaltepeter Thoughts?

@kreuzerk I debated that a bunch in my head too. I agree that three has a cleaner schema, we could always start separate unless it really doesn't make sense. I imagine any shared bits could be abstracted out easy on code side, maybe schema as well.

I think I lean towards 3 unless it's unruly when we get into it.

commented

๐ŸŽ‰ This issue has been resolved in version 1.0.0 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€