angular-architects / module-federation-plugin

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Import compensation for React

sedx opened this issue · comments

We are used Native Federation with Vite and esbuild adapter.

Adapter is not call compensateExports for named imports.

Instead used named imports:

import { lazy }  from 'react';
const Lazy = lazy(() => /** */);

We should use default:

import React from 'react';
const Lazy = React.lazy(() => /** */);

It's not comfortable because:

  • with "jsx": "react-jsx" in tsconfig.json we no need direct import React
  • some libraries use named imports of hooks and etc. and can not find it

I uncomment call of compensateExports #501 and now it works fine.

FIY:
@jogelin - you add todo with question about should we delete unused compensateExports, looks like it's usable feature.
@manfredsteyer - you comment call of compensateExports, maybe you have some reason for do it