Giters

angrykoala / wendigo

A proper monster for front-end automated testing

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

waitFor is deprecated

angrykoala opened this issue · comments

commented

Puppeteer waitfor method is deprecated, 2 possible solutions:

  • Change Wendigo's waitFor to support new Puppeteer methods
  • Deprecate waitfor in favor of Puppeteer approach
commented

To avoid compatibility issues, the same method waitFor will be kept for wendigo 3.0 (with the same behavior). this method, under the hood will call the specific methods from Puppeteer instead of the deprecated waitFor:

  • waitForXPath
  • waitForSelector
  • waitForFunction

This is to keep wendigo API simple, but future methods (waitForSelector and waitForFunction) could be added if deemed necessary.

The main limitation of this approach is that waitForFunction cannot be called with a string (it would be detected as a selector instead). This can still be done by accessing puppeteer page directly: browser.page.waitForFunction

commented

This change will be available in wendigo 3.0