angelsix / fasetto-word

The new chat application for Fasetto, completely open-source :)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Window "resize"

BXS0 opened this issue · comments

commented

im not sure if i should compare your application with a normal windows one but there is another one issue:
when you grab and drug the bottom or the top edge and hit to the top-bot side the new size of the windows is not correct, there is a gap from the top side of windows and the really top of the screen.
Also i know that is not the right place to do questions but i couldn't find better. So i apologize if you already explained it at your videos but my question is: Why you have this hook at "Fasseto.Word\Window\WindowsResizer.cs" Line:268

            case 0x0024:/* WM_GETMINMAXINFO */

while this case is there at 0024 the application window cant resize the height and the width more than the main monitor dimensions. You need that for some reason ? a Windows app like Paint for example can get the height and the width of the virtual monitor. At this case if you relapse the 0024 with 0000 for example everything seems to work perfectly, except the fact that you can use all monitors now.
thank you in advance

I don't get that issue. I drag the window to the very top and the window docks top and bottom and removes the border.

I drag it close to top and then close to bottom and same thing, I get perfect top to bottom fill

screenshot_1

For 0024 that is because we are intercepting the entire message pump. We only want to update the window size when the system requests it via a message type of WM_GETMINMAXINFO.

commented

hmm. in my case i get this no mater the monitor (tested with 2 monitor extended layout & single monitor)
maybe we need a third tester.
hmm

But while you do this you lose the space you can use to work on.
as you can see notepad++ and paint for example can use the full width of the virtual monitor but the fasseto app Can't! this is what i get as the full width of fasseto
width

commented

with a very quick fix-change to do the 0024 0000 you can use the full size of your workstation like this:
dothis

Ok you are really making me work for this aren't you. Determined to not be beaten, I dare you to break the code now 👍

df7986e

Please test, confirm and I can close this bug.

PS. There are now no limitations, workarounds or tweaks, this window will behave just like standard windows, even the max size

commented

ow that is a lot of changes.. for more bugs!!
i cant wait for the database functionality :D
and no no we dont push you to work on this! see? i gave you 1 day off till to "confirm"
so:
*this is a capture from my top left corner, same thing at top right for dorking. the squaring tricky part works at bot corners too
ezgif com-video-to-gif

take your time! its your unprofitable project!
im just letting you know things i noticed
Good Luck!

I don't see any bug in that animation? The border removing and going to flat when near corners is by design if that's what you mean?

commented

yes, and ok if you want this. just looks like strange because it changes the window size too. anyway.
the other thing you see at the gif is that if you dork the window at top there is a not normal gap too

Docking just at the top we keep the border and drop Shadow. I can change it so it goes borderless if even one corner goes to an edge? So it looks the same as when in a corner?

I'll play with it tomorrow if I get time before I go away see if I can come up with a natural solution

commented

no no, i dont think the problem is that is borderless or not.
the whole window likes to operate normally at this case (when you dock it on top edge).
i thing the issue is that there is a huge gap from the white side of the window that you can see and the real size of the window that is transparent.
you can see on this image that all of the 3 windows are docked at the top but the WORD looks alone and problematic..
gap
maybe this part i painted red is the problem. is it possible to be smaller? or zero? so the window will be curved but the sides wont have some spare pixels. its just my opinion of how i used to see applications.
but since its a very custom solution you can leave it as it is.
redgap

the sure thing that dont look like normal is on the previous gif. while you corner it and the window loose the curve and border you gain some extra space. for example at the bot right you couldnt see the "Parnell" green option but while you just go borderless you can see it. looks like you gain some pixels from nowhere.
anyway i dont think you should care about this at the moment. i think you have a long way till an official release

Yes that is the part I am talking about. The window itself includes that transparent area for the drop shadow we make around the window. So technically that is the windows edge. Hence why docking docks there.

We are smart about when we remove that border, and by default we remove the rounded edges too.

Anyway, it clearly looks a bit odd... so I fixed them both.

Test and confirm please: d8576a7

commented

All fine and smooth!
now you can lock it once for ever :)