Incorrect cast of ColumnType.float to DECIMAL in SQL

Question

Incorrect cast of ColumnType.float to DECIMAL in SQL

kevinelliott opened this issue 5 years ago · comments

*This issue was automatically moved to: angel-dart/angel#213.

Tobe Osakwe · Answer 1 · Mon Dec 09 2019 06:10:29 GMT+0800 (China Standard Time)

Question - does the generated migration file also have decimal? Or float? IIRC I specifically added the DECIMAL casts because the postgres library returned doubles as strings (not sure if it still does this, but didn't want to fix what wasn't broken).

Kevin Elliott · Answer 2 · Mon Dec 09 2019 06:57:49 GMT+0800 (China Standard Time)

I don't use the migrations (database is defined elsewhere), so I can't say there. Postgres returns the FLOAT as a number not a string.

Kevin Elliott · Answer 3 · Thu Dec 12 2019 06:13:27 GMT+0800 (China Standard Time)

@thosakwe Any further update here?

Tobe Osakwe · Answer 4 · Thu Dec 12 2019 06:14:35 GMT+0800 (China Standard Time)

Sorry, won't be able to do much this week, as I have final exams.

Kevin Elliott · Answer 5 · Fri Dec 13 2019 02:00:28 GMT+0800 (China Standard Time)

OK understandable, I will fork and make some kind of correction for myself in the meantime. Thanks.

Tobe Osakwe · Answer 6 · Fri Dec 13 2019 02:59:06 GMT+0800 (China Standard Time)

Feel free to send in a PR if you get it fixed on your end.