Giters

andyletzhang / SwatGrains

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some Legacy Fixes

andyletzhang opened this issue · comments

commented

A few things we should streamline before getting deeper into the Z vs. P trends in BondInfo:

  1. read_data() in BondInfo_Analysis, for some unclear reason, filters out all trials which aren't listed in the corresponding Pressures.txt file. This means we need to generate a Pressures file before reading any BondInfo data. We should just return the whole dataset using read_data() and filter out trials whenever it's necessary to merge these together.

  2. right now we multiply pressure by rs2 in Cell 1.5 of BondInfo_Analysis, but that poses issues if we're also writing to Pressures.txt. The easiest fix is to just make the full jump to using prs2 everywhere, which means writing this to the file the first time through in Info_Analysis and leaving it alone afterward.