The --output-keys option not working?
laseanb opened this issue · comments
First off, Thank You for your work on this tool!!!!
While using it I noticed that the -o or --output-keys option doesn't seem to work in v1.0.3 though it does work in v0.9.1. Running with the verbose option, I noticed that no matter whether I use -o or -x, the excludeKeys always got filled with the args while the outputKeys array remained empty.
ie json-diff -v --output-keys "one" <(echo '{"one":"1","two":"2","three":"3"}') <(echo '{"one":"1","two":"2","four":"4"}')
Looking at this commit (91da5ee?diff=unified), it looks like #var(outputKeys) was changed to #var(excludeKeys) which makes it so that the args passed to either -x or -o options always get funneled to excludeKeys.
Is this a bug?
Hi, yes, thank you, looks like a typo/bug in the usage section. I'll try to
get to it shortly, unless you'd like to post a PR for it. -Thanks! -Eric
…On Fri, May 12, 2023 at 3:09 PM laseanb ***@***.***> wrote:
First off, Thank You for your work on this tool!!!!
While using it I noticed that the -o or --output-keys option doesn't seem
to work in v1.0.3 though it does work in v0.9.1. Running with the verbose
option, I noticed that no matter whether I use -o or -x, the excludeKeys
always got filled with the args while the outputKeys array remained empty.
ie json-diff -v --output-keys "one" <(echo
'{"one":"1","two":"2","three":"3"}') <(echo
'{"one":"1","two":"2","four":"4"}')
Looking at this commit (91da5ee?diff=unified
<91da5ee?diff=unified>),
it looks like #var(outputKeys) was changed to #var(excludeKeys) which
makes it so that the args passed to either -x or -o options always get
funneled to excludeKeys.
Is this a bug?
—
Reply to this email directly, view it on GitHub
<#115>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6OIPP2G3FAQ2LXX35X2GTXF2DG3ANCNFSM6AAAAAAX74ZZ5Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>