Ensure that brew is in the environment

Question

Ensure that brew is in the environment

vesper8 opened this issue a year ago · comments

This is a followup to #3

I'm using 0.0.4 now and still having an issue even after specifying the path to my brew file which was already located at the default anyway /usr/local/bin/brew

I get this error when trying to use Orion:

On my system brew refers to /opt/homebrew/bin/brew, and ibrew refers to /usr/local/bin/brew

I believe the issue is on this line https://github.com/AndrewMD5/orion/blob/ed3e6a5f39776a33c8253045a0aa986a9adecf4c/orion/ShellWrapper.cs#L167

Shouldn't brew list game-porting-toolkit be changed to $({BrewPath} list game-porting-toolkit ?

Indeed on my system if you type brew list game-porting-toolkit you get

Error: No such keg: /opt/homebrew/Cellar/game-porting-toolkit

But if you type /usr/local/bin/brew list game-porting-toolkit you get

/usr/local/Cellar/game-porting-toolkit/1.0/bin/function_grep.pl
/usr/local/Cellar/game-porting-toolkit/1.0/bin/widl
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wine32on64
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wine32on64-preloader
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wine64
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wine64-preloader
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winebuild
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winecpp
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winedump
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wineg++
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winegcc
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winemaker
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wineserver
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wmc
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wrc
/usr/local/Cellar/game-porting-toolkit/1.0/include/wine/ (1150 files)
/usr/local/Cellar/game-porting-toolkit/1.0/lib/external/ (13 files)
/usr/local/Cellar/game-porting-toolkit/1.0/lib/wine/ (2329 files)
/usr/local/Cellar/game-porting-toolkit/1.0/share/man/ (14 files)
/usr/local/Cellar/game-porting-toolkit/1.0/share/wine/ (133 files)

C-Bass · Answer 1 · Sat Jun 10 2023 13:38:24 GMT+0800 (China Standard Time)

I would like to add that I've moved gameportingtoolkit and the other two files to /usr/local/bin so I can easily call them from anywhere.

And I've made modifications to those files as well to replace brew by arch -x86_64 /usr/local/bin/brew

So perhaps what is needed her is for you to let us also specify the path to gameportingtoolkit ?

Everything works and I'm able to play dx12 games with my setup btw.

Hoping to be able to use your nifty cli tool soon : )

andrew · Answer 2 · Sun Jun 11 2023 01:53:25 GMT+0800 (China Standard Time)

try this release and lmk if it works: https://github.com/andrewmd5/orion/releases/tag/0.0.5

C-Bass · Answer 3 · Sun Jun 11 2023 03:00:00 GMT+0800 (China Standard Time)

Hrm.. I see you've updated that line, but I'm still getting the same error for some reason


orion
                 _
   ___    _ __  (_)   ___    _ __
  / _ \  | '__| | |  / _ \  | '_ \
 | (_) | | |    | | | (_) | | | | |
  \___/  |_|    |_|  \___/  |_| |_|

No config file found. Would you like to create one now? [y/n] (y): y
Enter the path to your x86-64 Homebrew binary: (/usr/local/bin/brew): /usr/local/bin/brew
Enter the path to your Wine prefix: ~/dx12-gaming
Checking for dependencies...
An error occurred while checking for dependencies.
System.Exception: gameportingtoolkit is not functioning correctly. Ensure that brew is in the environment.
  at async Task Ptk.ShellWrapper.EnsureGamePortingToolkitAvailability(CancellationToken cancellationToken)
  at async Task Program.<Main>$(string[] args)

If I run

/usr/local/bin/brew list game-porting-toolkit

Then I get this output

/usr/local/Cellar/game-porting-toolkit/1.0/bin/function_grep.pl
/usr/local/Cellar/game-porting-toolkit/1.0/bin/widl
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wine32on64
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wine32on64-preloader
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wine64
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wine64-preloader
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winebuild
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winecpp
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winedump
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wineg++
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winegcc
/usr/local/Cellar/game-porting-toolkit/1.0/bin/winemaker
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wineserver
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wmc
/usr/local/Cellar/game-porting-toolkit/1.0/bin/wrc
/usr/local/Cellar/game-porting-toolkit/1.0/include/wine/ (1150 files)
/usr/local/Cellar/game-porting-toolkit/1.0/lib/external/ (13 files)
/usr/local/Cellar/game-porting-toolkit/1.0/lib/wine/ (2329 files)
/usr/local/Cellar/game-porting-toolkit/1.0/share/man/ (14 files)
/usr/local/Cellar/game-porting-toolkit/1.0/share/wine/ (133 files)

Not sure what's wrong. Can you give me the full command that is being run so I can paste it in my terminal and see what's going on maybe?

Thanks!

Ftps · Answer 4 · Sat Jun 17 2023 20:25:59 GMT+0800 (China Standard Time)

Does this command work?
arch -x86_64 zsh -c 'eval \\\"$(/usr/local/bin/brew shellenv)\\\"; brew list game-porting-toolkit'

C-Bass · Answer 5 · Mon Jun 19 2023 15:08:53 GMT+0800 (China Standard Time)

@Tps-F no that command results in arch: posix_spawnp: zsh: Bad CPU type in executable

Ftps · Answer 6 · Mon Jun 19 2023 15:37:11 GMT+0800 (China Standard Time)

I think you don't install Rosetta
try this
softwareupdate --install-rosetta

C-Bass · Answer 7 · Mon Jun 19 2023 21:44:23 GMT+0800 (China Standard Time)

@Tps-F I have done that. To be clear the porting toolkit is fully working on my machine and I've already played dozens of games with it.

andrew · Answer 8 · Wed Jun 21 2023 18:26:19 GMT+0800 (China Standard Time)

@Tps-F I have done that. To be clear the porting toolkit is fully working on my machine and I've already played dozens of games with it.

Can you run this and share what it says?
orion.zip

andrew · Answer 9 · Wed Jun 21 2023 18:41:40 GMT+0800 (China Standard Time)

@Tps-F I have done that. To be clear the porting toolkit is fully working on my machine and I've already played dozens of games with it.

Also, here is another build that uses zsh directly instead; let me know if either work.
orion.zip

Ftps · Answer 10 · Wed Jun 21 2023 20:06:38 GMT+0800 (China Standard Time)

@vesper8
Can you give me information about the terminal you are using, etc.?

and I would also like to know the results of the following two
uname -m
arch -x86_64 uname -m

It is normal to come back with arm64, x86_64, in order from the top

@andrewmd5
I don't think you're asking me, but it works no differently than normal in my environment!

C-Bass · Answer 11 · Wed Jun 21 2023 21:00:51 GMT+0800 (China Standard Time)

@Tps-F

arm64 and x86_64 are indeed the two return values for those two commands.

I'm using iTerm2 and using zsh

@andrewmd5

Your latest zip file above just works.. no issues.. here is the output:


./orion
                 _
   ___    _ __  (_)   ___    _ __
  / _ \  | '__| | |  / _ \  | '_ \
 | (_) | | |    | | | (_) | | | | |
  \___/  |_|    |_|  \___/  |_| |_|

No config file found. Would you like to create one now? [y/n] (y): y
Enter the path to your x86-64 Homebrew binary: (/usr/local/bin/brew): /usr/local/bin/brew
Enter the path to your Wine prefix: ~/dx12-gaming
Checking for dependencies...
All dependencies are installed.
Checking for updates...
No updates are available.
Enable HUD? [y/n] (y): n
Enable esync? [y/n] (n): n
Killing previous instances of Wine processes...
Launching Steam...
Press Command+C to exit.

Ftps · Answer 12 · Wed Jun 21 2023 21:02:57 GMT+0800 (China Standard Time)

@vesper8

Sorry for the delay, but I was able to reproduce the problem on my end.
You were right, it depended on the brew path.

andrew · Answer 13 · Thu Jun 22 2023 08:03:05 GMT+0800 (China Standard Time)

@Tps-F

arm64 and x86_64 are indeed the two return values for those two commands.

I'm using iTerm2 and using zsh

@andrewmd5

Your latest zip file above just works.. no issues.. here is the output:


./orion
                 _
   ___    _ __  (_)   ___    _ __
  / _ \  | '__| | |  / _ \  | '_ \
 | (_) | | |    | | | (_) | | | | |
  \___/  |_|    |_|  \___/  |_| |_|

No config file found. Would you like to create one now? [y/n] (y): y
Enter the path to your x86-64 Homebrew binary: (/usr/local/bin/brew): /usr/local/bin/brew
Enter the path to your Wine prefix: ~/dx12-gaming
Checking for dependencies...
All dependencies are installed.
Checking for updates...
No updates are available.
Enable HUD? [y/n] (y): n
Enable esync? [y/n] (n): n
Killing previous instances of Wine processes...
Launching Steam...
Press Command+C to exit.

great, i’ll get a release out with my fixes

andrew · Answer 14 · Thu Jun 22 2023 09:40:52 GMT+0800 (China Standard Time)

fixed in v0.0.7

https://github.com/andrewmd5/orion/releases/tag/0.0.7