andrewiggins / v8-deopt-viewer

Looks like there is one new column in the CSV and we trip over that. Ours has only 9 parsers whereas recent versions of v8 write 10 columns.

Our parser:

v8-deopt-viewer/packages/v8-deopt-parser/src/propertyICParsers.js

Lines 68 to 78 in 6af15a4

    
           export const propertyICFieldParsers = [ 
        
           	parseInt, // profile code 
        
           	parseInt, // line 
        
           	parseInt, // column 
        
           	parseIcState, // old_state 
        
           	parseIcState, // new_state 
        
           	parseInt, // map ID 
        
           	parseString, // propertyKey 
        
           	parseString, // modifier 
        
           	parseString, // slow_reason 
        
           ];

V8: https://source.chromium.org/chromium/chromium/src/+/main:v8/tools/system-analyzer/processor.mjs;l=69-72?q=StoreIC&ss=chromium%2Fchromium%2Fsrc&start=41

EDIT: This folder might also be of interest: https://source.chromium.org/chromium/chromium/src/+/main:v8/tools/system-analyzer/

Some more information:

Node 15/16:

StoreIC,0x3107e6a754d5,676125,534,44,X,X,0x000000000000,map,,

Node <= 14

StoreIC,0xf2e574a7855,534,44,X,X,0x000000000000,map,,

Not sure what the third number is referring to.

I believe it is the current time: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/logging/log.cc;l=1789;drc=293ee2451677a4456a02b3dea9e0ef2a557db505

	export const propertyICFieldParsers = [
	parseInt, // profile code
	parseInt, // line
	parseInt, // column
	parseIcState, // old_state
	parseIcState, // new_state
	parseInt, // map ID
	parseString, // propertyKey
	parseString, // modifier
	parseString, // slow_reason
	];

IC format in log file has changed