Paths broken when adding multiple subdirs of /

Question

Paths broken when adding multiple subdirs of /

tlotze opened this issue 2 years ago · comments

When I put multiple directories with the same call, they will be stored as subdirectories of the common parent. However, when I do this with different subdirectories of the filesystem root, such as # bupstash put /etc /home, the paths will be broken:

# bupstash list-contents
drwxr-xr-x -         2022/11/07 11:05:36 .
drwxr-xr-x -         2022/11/14 19:25:52 tc
drwxr-xr-x -         2022/02/08 09:41:19 ome
...

and bupstash get --pick will also refer to those mangled paths.

andrewchambers · Answer 1 · Tue Nov 15 2022 11:56:24 GMT+0800 (China Standard Time)

Thanks for the report - it seems like this slipped through because the test suite can't test the root directory so easily.

andrewchambers · Answer 2 · Mon Nov 21 2022 17:37:39 GMT+0800 (China Standard Time)

This has been fixed in master and will be in the next bug fix release.

Klemens Nanni · Answer 3 · Mon Jan 02 2023 00:38:03 GMT+0800 (China Standard Time)

This has been fixed in master and will be in the next bug fix release.

This happens when testing #363 on top of 0.12.0, which is what I did through the official OpenBSD port/package, where tests failed unexpectedly.

This PR lacked a reference to the actual fix, so here it is: a73fd83.

andrewchambers · Answer 4 · Mon Jan 02 2023 05:59:10 GMT+0800 (China Standard Time)

I will try to do a release in the next week or so we can get this fix out.