andrewchambers / bupstash

Easy and efficient encrypted backups.

Home Page:https://bupstash.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

fstx2: Open directories to flush before performing renames

andrewchambers opened this issue · comments

I think this is the strictly correct way, the current way may suffer from an extremely rare lost directory fsync when the rename + fsync spans the natural os page flushing. (Note to actually experience this would be very unlikely, especially on linux where many filesystems go to read only on io error.)