andreoliwa / nitpick

Enforce the same settings on multiple projects

Home Page:https://nitpick.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support GitHub Enterprise Server

Wilhelmsson177 opened this issue · comments

Problem

I want to use nitpick with a style file located in a private repository on a GitHub Enterprise Server to have a consistent style of my settings within my organization.

Possible solution

Currently, the GitHub URLs are hard coded in nitpick GitHub Fetcher implementation. The idea is to set an environment variable with the GitHub Enterprise Server URL or extend the URL of the remote style with the URL of the GitHub Enterprise Serer URL.

I tried to just set the URL in

GITHUB_COM = "github.com"
on my local installation, but that did not solve my issue. I'm not familiar with the entire URL validation process and did not want to dig to deep into this issue.

For more information, see the CONTRIBUTING guide.

👋🏻 Hello, and thanks for the request.

I don't have access to any GitHub Enterprise Server.
My idea to test this (when I have time):

  1. Replace the URL as you did.
  2. See what breaks, and fix the code to make it work.
  3. Give you the branch so you can test it on your server and let me know.

Any other ideas?

Hello @andreoliwa

sounds like a plan. I can assist on testing the new feature.

Hello @andreoliwa,

did you already have a chance to take a look at the issue?

Didn't have time yet... 😐