Disallow all bare try-except clauses
wagoodman opened this issue · comments
Today we have several noqa: E722 statements as well as ignoring blank noqa statements (here and here). We should:
- not allow bare noqa statements, as this can hide a lot of issues
- not allow any E722 exceptions, as this is a popular antipattern in this codebase and has lead to production regressions
Additionally, all except: blocks should log the exception and some useful context, to make feed failures easier to diagnose from logs.
All the refactors we planned under this issue to make it easier / safer to work in Vunnel are implemented.