Giters

anaynayak / buildnotify

A system tray based build status notification app for cctray.xml feeds.

Home Page:https://anaynayak.github.io/buildnotify/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Basic Auth credentials

anaynayak opened this issue · comments

commented

Originally reported by: Anonymous

Go Continuous Delivery (https://go.cd/) has the feed URL protected by basic authentication, and currently I have to add that information to the URL in the form of http://user:password@hostname:8153/.

That's not very nice, because now the debugging output to the console contains my password.

It would be nice if buildnotify offered a separate dialog for entering the basic auth credentials, and did not show the password unless when prompted for it.

commented

Original comment by Anay Nayak (Bitbucket: Anay, GitHub: Anay):

Makes sense. I think there are a few changes that need to happen:

  1. Remove user creds from the url
  2. Use keychain for storing the password
  3. Remove password from the logs
commented

Original comment by Anay Nayak (Bitbucket: Anay, GitHub: Anay):

I have pushed a few commits to master which take care of #1 and as a side effect #3 as well. I'll continue on using a keychain for storing the passwords.

If you have any existing servers configured (with creds), you'd probably have to reconfigure those.

commented

Original comment by Anay Nayak (Bitbucket: Anay, GitHub: Anay):

This is now in place and leverages the keychain for storing the passwords.