Cannot accept self-signed TLS certificate
anaynayak opened this issue · comments
Originally reported by: Anonymous
It would be nice buildnotify offered an option to accept invalid/self-signed certificates
Original comment by Anay Nayak (Bitbucket: Anay, GitHub: Anay):
This has now been pushed with b0ea89d4a52b2e6f70b3957454626237b97d1279 commit .
A invalid certificate now generates an additional prompt for the user to skip SSL check. If the user accepts, this information is stored in the config so that we can do that as part of the normal poll. This information is stored on a per server basis.
@akshaymankar I'm using version 2.0.0 and not getting the prompt to skip the SSL check 😕
I suspect the switch over to requests library has reintroduced this bug since the original logic no longer works.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@anaynayak any updates on this?
@Zialus I just checked and it should be working. Let me know if you see any issues.
Steps to reproduce with a dummy server (in a buildnotify checkout directory):
openssl req -newkey rsa:2048 -new -nodes -x509 -days 3650 -keyout key.pem -out cert.pem
npx http-server@0.12.3 -e json -S
Adding https://localhost:8080/data/cctray.xml gives a certificate warning and on clicking yes, the list of projects is displayed.
@anaynayak, thanks for the update
It seems to be working if I use the git version but not the released version
I have release v2.1.0 to pypi and the snapcraft should build automatically. I'm not fully sure how this flows downstream to archlinux.
No worries, thanks for the update.