Time Data appears to be off

Question

Time Data appears to be off

anaynayak opened this issue 12 years ago · comments

Originally reported by: Anonymous

When using the option to display last build time in the dropdown, the times there are very off.

My CI server is a modified version of cc.rb (though nothing that messes with time, just added some security, and a few css changes).

My server is in UTC, I am in EST.

Changing the drop down in the server configuration dialog does nothing.

Bitbucket: https://bitbucket.org/Anay/buildnotify/issue/13

Anay Nayak · Answer 1 · Tue Nov 06 2012 05:19:41 GMT+0800 (China Standard Time)

Original comment by Robert Cotey (Bitbucket: coteyr, GitHub: coteyr):

Sorry, that was my issue didn't realize I wasn't logged in.

Anay Nayak · Answer 2 · Tue Nov 06 2012 06:37:01 GMT+0800 (China Standard Time)

Original comment by Robert Cotey (Bitbucket: coteyr, GitHub: coteyr):

Not used to working on bitbucket or with hg so if I borked something out of alignment, just let me know. But I forked, fixed and submitted a pull.

Anay Nayak · Answer 3 · Wed Nov 07 2012 00:29:08 GMT+0800 (China Standard Time)

Original comment by Anay Nayak (Bitbucket: Anay, GitHub: Anay):

Thanks for taking the time to fix this issue. The only question that I had was about the #wrong on https://bitbucket.org/coteyr/buildnotify/changeset/96048722e5324a8e24df46794d9f9cc4f61c80dc#Lbuildnotifylib/projects.pyT121 . I'm guessing you had concerns with the way the url attribute was now being passed ? I'll merge the changes in but am interested in knowing your thoughts.

Anay Nayak · Answer 4 · Sun Nov 11 2012 15:53:00 GMT+0800 (China Standard Time)

Original comment by Anay Nayak (Bitbucket: Anay, GitHub: Anay):

Merged pull request #1 based on changed done by Robert. Thanks for the help :)

Anay Nayak · Answer 5 · Mon Nov 12 2012 01:37:33 GMT+0800 (China Standard Time)

Original comment by Robert Cotey (Bitbucket: coteyr, GitHub: coteyr):

It was a left over comment, it shouldn't be there. I put www.google.com hard coded as a URL to test that the getter and setter was storing values properly. I stuck a #WRONG there so that I would remember to change it. I changed it, but forgot to move the comment.