ADF4360 Incorrect Mask Used.

[Anthony Clark]

ADI,

I'm unsure of the stability of this driver in general but I am attempting to use it - I'll report my success here or on the forum as the documentation is sparse. I'm comparing the register outputs with the EVAL kit Windows software provided by ADI.

When doing some checks, the function __adf4360_power_down line 561 seems to use the MUXOUT Mask accidentally. It should change from:

val = st->regs[ADF4360_CTRL] & ~ADF4360_ADDR_MUXOUT_MSK;

to:

val = st->regs[ADF4360_CTRL] & ~ADF4360_ADDR_PWR_DOWN_MSK;

https://github.com/analogdevicesinc/linux/blob/master/drivers/iio/frequency/adf4360.c#L561

[Michael Hennerich]

Confirmed this is indeed a bug. Thanks for reporting.

[Anthony Clark]

Thanks @mhennerich. I appreciate the attention and time!