ampproject / amp-sw

A drop in service worker library to help your AMP pages gain network resiliency in 1 line

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AmpDocumentNetworkFirst.makeRequest return is not nullable but method body implies that it might be nullable

erwinmombay opened this issue · comments

inside the body of makeRequest in the AmpDocumentNetworkFirst class there is a check for request where it could be nullable but we return request anyways as the base case and don't state it in the method signature return type.

question really is, does calling makeRequest return something that is nullable from the NetworkFirst implementation in workbox?