amplitude / itly-sdk-jvm

Iteratively Analytics SDK for JVM β€” Android, Kotlin & Java

Home Page:https://iterative.ly

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrading segment analytics library to 3.*

pavel-snyk opened this issue Β· comments

πŸ‘‹

at the moment plugin-segment uses segment analytics:2.1.1 dependency and Retrofit1 as a transitive one.

Do you think about upgrade to segment analytics:3.* versions which uses Retrofit2?

Our use case: we have internal API service using Retrofit2 under the hood and now we force Retrofit2 with Gradle constraints.
I think upgrading to latest Segment analytics library is good from security point of view segmentio/analytics-java#148

I'm happy to raise a PR if you consider upgrading the library.

Hi @pavel-snyk thank you for the feedback!

Upgrading to the latest Segment analytics:3.+ would be great. If you would like to submit a PR I will happily review and get it merged.

Random mention - we had issues before in Java using OkHttp 4. Thankfully it looks like Retrofit 2 is still using OkHttp 3.14.9 so I think the upgrade should go smoothly.

Thanks again.