RV1-01: Function Visibility Optimization
thegostep opened this issue · comments
| type | severity | location |
|---|---|---|
| Gas Optimization | Informational | https://github.com/ampleforth/token-geyser-v2/blob/c970676aaecb08e942fe1088a4b1ddcb26655fe6/contracts/RouterV1.sol%23L26-L33 |
Description:
The linked function is declared as public , contains array function arguments and is not invoked in any of the contract's contained within the project's scope.
Recommendation:
We advise that the functions' visibility specifiers are set to external and the array-based arguments change their data location from memory to calldata , optimizing the gas cost of the function.