amphp / websocket-client

Async WebSocket client for PHP based on Amp.

Home Page:https://amphp.org/websocket-client

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing `$closeTimeout` property

lt opened this issue · comments

commented

Not sure if the socket is being closed from the remote end, or the local end due to a timeout, but getting the following notice spam.

Notice: Undefined property: Amp\Websocket\Rfc6455Endpoint::$closeTimeout in vendor/amphp/websocket/lib/Rfc6455Endpoint.php on line 428

@bwoebi I guess we should assign null instead of unset the closeTimeout

Urgs, I always forget that unset() actually removes them :x … Will fix.