Missing commands

Question

Missing commands

brstgt opened this issue 2 years ago · comments

Hi guys,

Today it added amphp/redis to our project to replace the classic phpredis implementation. I noticed that a couple of commands are missing - e.g. zrangebyscore, zrevrangebyscore and others.

Those commands are quite simple to implement. Would you accept an MR? What are your requirements on tests etc?

Thanks :)

Niklas Keller · Answer 1 · Sat Oct 01 2022 03:23:27 GMT+0800 (China Standard Time)

Hey Benjamin,

sure, we'll accept PRs for any missing commands. Tests would be great to ensure things work correctly. They're usually very simple to write as well. 🙂

Aaron Piotrowski · Answer 2 · Sat Dec 31 2022 13:02:02 GMT+0800 (China Standard Time)

Looks like we forgot to close this after merging these commands in #77. Tagged as v1.1.0.

Niklas Keller · Answer 3 · Sat Dec 31 2022 22:00:54 GMT+0800 (China Standard Time)

@trowski Seems like you didn't actually tag anything?

Aaron Piotrowski · Answer 4 · Sat Dec 31 2022 23:07:10 GMT+0800 (China Standard Time)

No, it seems I either forgot to push or the push failed. Since I didn't actually tag, should we review and make changes to #78, merge, then tag?

Benjamin Roth · Answer 5 · Sun Jan 01 2023 02:18:34 GMT+0800 (China Standard Time)

Aaron Piotrowski ***@***.***> schrieb am Sa. 31. Dez. 2022 um 16:07:

…

No, it seems I either forgot to push or the push failed. Since I didn't actually tag, should we review and make changes to #78 <#78>, merge, then tag? — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACRAZ4FXSCJPV3IVQLVCMLWQBD2RANCNFSM6AAAAAAQZ7CN5E> . You are receiving this because you authored the thread.Message ID: ***@***.***>