amphp / http-server

Line 104 in a7aeae8

    
           $this->boundServers[$server->getAddress()->toString()] = $server->getResource();

http-server/src/Server.php

Line 309 in a7aeae8

$onAcceptable = \Closure::fromCallable([$this, 'onAcceptable']);

http-server/src/Server.php

Line 318 in a7aeae8

    
           \stream_context_set_option($server, "ssl", "alpn_protocols", \implode(", ", $protocols));

http-server/src/Server.php

Line 331 in a7aeae8

if (!$socket = @\stream_socket_accept($server, 0)) {

SocketServer support tls and accept methods. So why http server use rar sockets instead of abstractions ?

This was afaik done for performance reasons, in particular all incoming client connections are (nearly) permanently alive and we just disable watching when our internal buffer limit gets reached.

It's in the end a lot of objects and enabling back and forth (if you consider ResourceInputStream->read() for example).
And this is in the hot path of the server...

p.s.: We technically could use the SocketServer API for accepting, but we'd definitely then have to unwrap the raw resource after accepting for performance. Also note that we have a common function for accepting from all bound sockets. With the socket server API you'd have essentially as many generators as server sockets…

It seems like all questions have been answered. If not, please respond with further questions, the issue can always be re-opened. 👍

Why direct sockets used instead of SocketServer ?