amphp / http-client

v5 Request::setBody should accept null because it did in v4. Also, WTF is up with int and float?

Lines 222 to 230 in 92b60c1

    
           public function setBody(string|int|float|RequestBody $body): void 
        
           { 
        
               $this->body = match (true) { 
        
                   \is_string($body) => new StringBody($body), 
        
                   \is_scalar($body) => new StringBody(\var_export($body, true)), 
        
                   $body instanceof RequestBody => $body, 
        
                   default => throw new \TypeError("Invalid body type: " . \gettype($body)), 
        
               }; 
        
           }

It does accept null in #322. Please provide any feedback regarding the body API there.

I really don't think it does, brotherman.

https://github.com/amphp/http-client/pull/322/files#diff-74d71c4d1f9d84b9b0d946ca96eb875274f95d60611611d84cc01cdf6ed04021R230-R233

	public function setBody(string\|int\|float\|RequestBody $body): void
	{
	$this->body = match (true) {
	\is_string($body) => new StringBody($body),
	\is_scalar($body) => new StringBody(\var_export($body, true)),
	$body instanceof RequestBody => $body,
	default => throw new \TypeError("Invalid body type: " . \gettype($body)),
	};
	}

BC break: v5 `Request::setBody` should accept `null`