amphp / file

An abstraction layer and non-blocking file access solution that keeps your application responsive.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Change to static methods like Loop::?

kelunik opened this issue · comments

Change to static methods like Loop::?

Is there any concrete advantage?

Having encapsulation and different getters and setters.

It's not more or less encapsulated with the function than with a static one.

Also, I see no benefit in having different getters and setters. The current solution works pretty nicely and has no drawbacks to me.

Changing it just for the sake of using a static accessor doesn't make much sense to me.