Project depends on TA-LIB
TheSnoozer opened this issue · comments
Describe the bug
When I see it correctly the project has removed the dependency to TA-LIB.
However it seems that the MAMA strategy is not yet replaced (here and here). It is also referenced as comment in my_strategy.
To Reproduce
- Call
market_miner: - See error:
Traceback (most recent call last):
File "/.venv/bin/market_miner", line 16, in <module>
from liualgotrader.miners.daily_ohlc import DailyOHLC
File "/.venv/lib/python3.8/site-packages/liualgotrader/miners/daily_ohlc.py", line 6, in <module>
from talib import MAMA
ModuleNotFoundError: No module named 'talib'
Expected behavior
Either depend on talib, or find a suitable replacement for the MAMA strategy.
Desktop (please complete the following information):
$ python --version
Python 3.8.0
$ pip freeze | grep liu
liualgotrader==0.0.82
@TheSnoozer thank you for your comment. Personally, I do use TALIB for my strategies that I write on top of the liu-framework. However, various users mentioned issues w/ compiling the library on Windows, which is why I took out the dependency. I will remove it from the market_miner, and leave it in the samples directory with a clear indication of the dependency.
To-be-released in 0.0.85
Hi,
yeah no worries. I have noticed the dependency in the strategies (e.g. this one) so I wasn't sure if this is now a required dependency for this project or not :-).
I have installed talib locally (on linux so I had no issue in installing) so feel free to fix whenever.
merged your PR it's now currently in master together with a collection of changes that I plan to release as 0.0.85 by end of the week. Thank you for your help, I added you as a contributor, and hope to see more stuff from you. Let me know if you have any issues/suggestions/comments or flames. Happy New Year!