test_close_fds/test_pass_fds fails on OpenIndiana
mtelka opened this issue · comments
I see following two test failures on OpenIndiana related to FD_CLOEXEC:
======================================================================
FAIL: test_close_fds (tests.test.FunctionalTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "$(BUILD_DIR)/tests/test.py", line 643, in test_close_fds
self.assertEqual(out, "['0', '1', '2', '3']")
AssertionError: "['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11[112 chars]30']" != "['0', '1', '2', '3']"
- ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27', '28', '29', '30']
+ ['0', '1', '2', '3']
======================================================================
FAIL: test_pass_fds (tests.test.FunctionalTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "$(BUILD_DIR)/tests/test.py", line 672, in test_pass_fds
self.assertEqual(out, str(inherited_str))
AssertionError: "['0'[13 chars]3', '4', '5', '6', '7', '8', '9', '10', '11', [301 chars]62']" != "['0'[13 chars]3', '33']"
- ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27', '28', '29', '30', '31', '32', '33', '34', '35', '36', '37', '38', '39', '40', '41', '42', '43', '44', '45', '46', '47', '48', '49', '50', '51', '52', '53', '54', '55', '56', '57', '58', '59', '60', '61', '62']
+ ['0', '1', '2', '3', '33']
Marcel, some of these test failures concern me because they suggest that
open Indiana is not fully posix compliant. You mentioned in another test
that the failure could be the result of open Indiana and not SH at all, so
unfortunately we cannot proceed on those tests unless open Indiana is ruled
out as the cause, something that you will need to show.
My suggestion to you is to pause on integrating SH and open Indiana unless
you have time to do a deep dive on these issues, because these failures are
affecting critical pieces of how SH works.
…On Fri, May 12, 2023, 6:54 AM Marcel Telka ***@***.***> wrote:
I see following two test failures on OpenIndiana related to FD_CLOEXEC:
======================================================================
FAIL: test_close_fds (tests.test.FunctionalTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "$(BUILD_DIR)/tests/test.py", line 643, in test_close_fds
self.assertEqual(out, "['0', '1', '2', '3']")
AssertionError: "['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11[112 chars]30']" != "['0', '1', '2', '3']"
- ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27', '28', '29', '30']
+ ['0', '1', '2', '3']
======================================================================
FAIL: test_pass_fds (tests.test.FunctionalTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "$(BUILD_DIR)/tests/test.py", line 672, in test_pass_fds
self.assertEqual(out, str(inherited_str))
AssertionError: "['0'[13 chars]3', '4', '5', '6', '7', '8', '9', '10', '11', [301 chars]62']" != "['0'[13 chars]3', '33']"
- ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27', '28', '29', '30', '31', '32', '33', '34', '35', '36', '37', '38', '39', '40', '41', '42', '43', '44', '45', '46', '47', '48', '49', '50', '51', '52', '53', '54', '55', '56', '57', '58', '59', '60', '61', '62']
+ ['0', '1', '2', '3', '33']
—
Reply to this email directly, view it on GitHub
<#673>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB7IKLN4AM5VZ4K5EEQNE3XFY6K7ANCNFSM6AAAAAAX7SDJKI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
Marking this as closed until OpenIndiana is better supported. I am open to accepting PRs that provide this support.