_fg validator seems to be overly strict

[Jack Gaino]

I noticed that the _fg validator only allows {"env", "fg", "cwd"} as kwargs, but it looks to me like at least ok_code is still used in an fg context.

I understand not wanting piped there, but should the restriction for ok_code be relaxed?

[Andrew]

That seems reasonable to me. Want to make a PR?

…

On Tue, Mar 21, 2023, 12:28 PM Jack Gaino ***@***.***> wrote: I noticed that the _fg validator <https://github.com/amoffat/sh/blob/aa8ed42bccfad4e1d08bf46397f19f12822f129e/sh.py#L1111> only allows {"env", "fg", "cwd"} as kwargs, but it looks to me like at ok_code is still used in an fg context <https://github.com/amoffat/sh/blob/aa8ed42bccfad4e1d08bf46397f19f12822f129e/sh.py#L1506> . I understand not wanting piped there, but should the restriction for ok_code be relaxed? — Reply to this email directly, view it on GitHub <#663>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB7IKKWMDRCZJBQ5MT4X33W5H6O7ANCNFSM6AAAAAAWC4PFP4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>