Giters

aminya / project_options

A general-purpose CMake library that provides functions that improve the CMake experience following the best practices.

Home Page:https://aminya.github.io/project_options/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

update to stable tagged version of WindowsToolchain

ClausKlein opened this issue · comments

commented

We are not allowed to fetch contents from internet on our company CI!

So the call to msvc_toolchain() fails on our Windows build while using project_options.

Too, I can't understand why you download ninja and other tools in this call?

IMHO, this should be done with setup-cpp?

commented

Feel free to add an option for it in a PR.

commented

I do Not understand the Toolchain and it is wrong to download exe fils while Build?
You are also using an untaged version!

commented

Since the windows toolchain is trying to be self-contained, I don't have any complaints about it. If you already have ninja installed, it should probably skip downloading.

commented

There is at leased one bug in our Toolchain version you use!

see MarkSchofield/WindowsToolchain@b249802

Map CMAKE_SYSTEM_PROCESSOR values to CMAKE_VS_PLATFORM_TOOLSET_ARCHITECTURE that identifies the tools that should be used to produce code for the CMAKE_SYSTEM_PROCESSOR.

commented

please note #156 too