Try to remove `Send` / `Sync` from `Resource`

Question

Try to remove `Send` / `Sync` from `Resource`

torkleyy opened this issue 6 years ago · comments

It might be worth exploring a version of shred that doesn't force anybody using the Dispatcher, which forces thread-safety on all resources.

Zakarum · Answer 1 · Mon Sep 10 2018 20:13:38 GMT+0800 (China Standard Time)

I wonder why dispatcher forces Send + Sync?
If only thread-local systems are added then Send + Sync shouldn't be required.
Ideally only non-thread-local systems with Fetch<T> should require T: Sync, and with FetchMut<T> - T: Send + Sync.

Thomas Schaller · Answer 2 · Mon Sep 10 2018 20:18:55 GMT+0800 (China Standard Time)

It's forced on resources because otherwise you couldn't access `Resources` from a system.

…

On Mon, Sep 10, 2018, 14:13 Zakarum ***@***.***> wrote: I wonder why dispatcher forces Send + Sync? If only thread_local systems are added then it Send + Sync shouldn't be required — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#97 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWFFuSFqAZT4W9RAgcj1ywAV7-c_6uxhks5uZld3gaJpZM4WhAoZ> .

Zakarum · Answer 3 · Mon Sep 10 2018 20:24:21 GMT+0800 (China Standard Time)

This means you need Resources to implement Sync. Doesn't mean you can store only Send + Sync types. Maybe you'd have to implement Sync manually for Resources.

Thomas Schaller · Answer 4 · Thu Apr 04 2019 00:00:32 GMT+0800 (China Standard Time)

I don't think there's any useful solution to this; !Send are best stored in systems and synchronized with the data in the world, so e.g. processing can happen in parallel.

There's also no construct that allows fast, efficient and type-safe access to !Send resources.