`bpk start` is closing terminal on windows
saideepesh000 opened this issue · comments
version: 0.0.59
@saideepesh000 please share your node and os version info
@all-contributors add @saideepesh000 for bug
I've put up a pull request to add @saideepesh000! 🎉
@saideepesh000 please share your node and os version info
Node v12.20.1
windows 10
@saideepesh000 I checked it with cmd and power-shell and it happens in them both, but weirdly the new windows terminal (https://www.microsoft.com/en-us/p/windows-terminal/9n0dx20hk701) just works fine. Was the previous versions of blazepack working fine for you?
@saideepesh000 I checked it with cmd and power-shell and it happens in them both, but weirdly the new windows terminal (https://www.microsoft.com/en-us/p/windows-terminal/9n0dx20hk701) just works fine. Was the previous versions of blazepack working fine for you?
Yes, previous versions were working fine, I think I directly upgraded from 52 to 59
@saideepesh000 I recently updated one of our lib called open and I think that is what causing it. I will probably downgrade it back.
@saideepesh000 I recently updated one of our lib called
openand I think that is what causing it. I will probably downgrade it back.
My Browseri is Firefox, I could see there is not option for firefox here
@saideepesh000 yes but that piece of code only runs for mac os users
@saideepesh000 can you try to uninstall blazepack and install 0.0.57 version
npm i -g blazepack@0.0.57
and check whether the issue still exists
@saideepesh000 can you try to uninstall blazepack and install 0.0.57 version
npm i -g blazepack@0.0.57and check whether the issue still exists
Ya, it's working fine on 57 👍
@saideepesh000 ok I updated open in v0.0.58 so that is the issue, will downgrade it in some time and will cut a release.
@saideepesh000 this issue has been fixed in v0.0.60, please check and let me know.
@saideepesh000 this issue has been fixed in v0.0.60, please check and let me know.
Yayyy it's working, but it's automatically starting the localhost 😄
@saideepesh000 did not get you, what you mean by automatically starting the localhost?
@saideepesh000 did not get you, what you mean by automatically starting the localhost?
I meant browser 😅
yes @saideepesh000 that is the expected behaviour right?
yes @saideepesh000 that is the expected behaviour right?
oh, lol, I'm not sure why, up until now I was not seeing this, I manually type localhost:3000, looool
@saideepesh000 there was a bug in windows and linux previously which prevented automatically opening the browser and it was recently fixed. If you don't want this behaviour you can do something like this
bpk start --browser=none