Results from Browser History are not appearing in the search results
pavinduLakshan opened this issue · comments
First off, congrats on the launch and thanks for making this extension. It is quite useful to search browser-related everything (tabs, history, bookmarks) with a single shortcut and without using a mouse.
That said, I have a bit problem that browser history can't be searched on Omni.
For example, I searched for "manhole". It is showing in my browser history as follows.
However, it is not showing in the omni search results.
It was the same when I searched using terms "plan", "Business", "Xcore". Do you know why it occurs?
My environment:
Browser: Brave (Version 1.34.80 Chromium: 97.0.4692.71 (Official Build) (64-bit))
OS; Windows 10 education
Thanks in advance.
I wasn't sure whether to include the history results by default. I made it searchable using the command only to avoid showing any sensitive data. Some users have raised concerns about the extension even having access to the browser history to begin with (for privacy reasons), so I am not sure how to feel about it.
Open to changing it though, unsure what people think!
You could make some sort of dropdown on the left of the search bar, then when the user tries to activate history ask for an optional permission
Yeah, could work. I think ideally I'd like to have a way for users to decide what they want to see, so they can customize if they see bookmarks, history, actions... and even in which specific order they want it to be. Not sure where that could go though, it would have to be prompted after install and accessible somewhere, probably as an action in the omnisearch, but maybe also through a popup by clicking on the icon in the toolbar, not sure.
Yeah, could work. I think ideally I'd like to have a way for users to decide what they want to see, so they can customize if they see bookmarks, history, actions... and even in which specific order they want it to be. Not sure where that could go though, it would have to be prompted after install and accessible somewhere, probably as an action in the omnisearch, but maybe also through a popup by clicking on the icon in the toolbar, not sure.
Options page might be nice? That could also have other settings that would make the ux a little nicer in general like:
- Themes (custom too?)
- Icon theme (instead of emojis maybe some phosphor icons or something)
- Search mode (for slow/fast computers)
- Fuzzy
- Exact
- What to search:
- Bookmarks
- History
- Tabs
- (request optional permissions if needed when checking)
- Revoke permissions button (revokes all except tabs)
- Customize keyboard shortcuts (might be tricky to implement though)
Perhaps settings could use something like this:
https://github.com/Explosion-Scratch/tab_grouping/blob/main/settings.html#L3-L11 (see settings.js for the code which I used to keep track of changes)
Maybe: ask for history permission, if granted – include history into search results?
Try typing /history before searching:
Also, maybe the previous code only searched from nearly 1000 history records. This should be a trade-off from the performance aspect, but the PR#70 should solve this problem, quickly search from all records, whether it is 20,000 or more Two hundred thousand.
+1 on having history searched directly from the search bar.