Display gym name on eject's notification
alucas opened this issue · comments
it's hard to see the name currently
I changed the text in the dev branch to give more place to the gym's name.
this time I got a "?" instead of the name of the gym
I think Snorlax need to be active when u put the mon in the gym so the app can store the gym's name for that mon.
I did a test now, disabled xposed and snorlax, put a mon in a very contested gym, then activated snorlax.
When the mon got ejected, the notification says ?
In other gym, the module display some guid like 12331-6546545-465465
The server doesn't send the gym's name the Pokemon is in, it only send an ID. So Snorlax normally save the gym's name when you put the Pokemon in the gym, at that time, we have the gym details.
"?" mean that Snorlax doesn't know the gym name.
Do you put your Pokemon in gym with Snorlax disabled ? Did you clean/reset on your phone that might have delete Snorlax saved information ?
I didn't personally reproduce that bug, so I don't really know where to search.
I always play with Snorlax, so I enter all of my pokemons with it enabled.
Although my phone frequently crashes. Could it that be related? If so, could Snorlax save those infos locally, in a sqlite file, or wherever it can recover them from after a reboot?
The data are already save on persistent memory. But yeah a crash can corrupts those data.
what about saving gym's names separately, maybe on a text file - and flushing it immediately? Not efficient, but most players are not going to have a billion gyms anyways and it could be crash-safer. I guess.