After running script - all the local /proc /dev/ /sys /run filesystems remain mounted
julian1 opened this issue · comments
shouldn't the cgroup mounts be unmounted on exit?
The enter-chroot script currently doesn’t unmount anything, i.e. it’s not a bug, but missing feature. I’ll add it.
@jirutka I see that you have done the work in the dev branch, could I ask if there's a reason it's not merged into the master branch?
It might be worthwhile to put warning about this in the readme on how you have to manually umount everything. I ran this script today on my machine and it worked fine. However, after I was done, I wanted to remove /alpine. Since I didnt know you had to umount, I ended up nuking my system by running sudo rm -rf /alpine....
This is mostly my incompetence but a warning would be good to put in the readme.
If this seems like a worthwhile comment, I will send a pull request.
@anjandev I've raised an PR to add a destroy script that can automatically delete the chroot as well.
@hoshsadiq thank you. I think it might be worthwhile to document (in the README perhaps?) deleting using the destroy script you made rather than merely rm -rf /alpine.
It's already mentioned at the end when the script is finished, same way the enter-chroot script is mentioned.
@hoshsadiq okay. Thanks!