use std.uri.encodeComponent instead of custom made urlEncode

Question

use std.uri.encodeComponent instead of custom made urlEncode

WebFreak001 opened this issue 8 years ago · comments

Jan Jurzitza commented 8 years ago

Relying on phobos will help avoiding bugs

Jan Jurzitza · Answer 1 · Thu Apr 21 2016 04:38:25 GMT+0800 (China Standard Time)

I see from a previous commit that you have used encodeComponent before. Is there any reason to not use it?

Akihiro Shoji · Answer 2 · Thu Apr 21 2016 21:15:37 GMT+0800 (China Standard Time)

Sorry, I had some reason to not use, but I forgot details. Maybe encodeComponent has some problem (the function may not support the specification which required by twitter).

Jan Jurzitza · Answer 3 · Thu Apr 21 2016 21:18:06 GMT+0800 (China Standard Time)

I checked the phobos documentation and it says its according to
RFC 3986, which is exactly what twitter/oauth requires (at the top it says RFC 3986)

Akihiro Shoji · Answer 4 · Thu Apr 21 2016 21:22:24 GMT+0800 (China Standard Time)

Ok, I don't have any reason to use my implemented version.
If you submit the pull request which replace urlEncode with encodeComponent, I'll merge it.