Giters

alpacahq / alpaca-trade-api-csharp

C# SDK for Alpaca Trade API https://docs.alpaca.markets/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update `AccountAcitvityType` enum values

OlegRa opened this issue · comments

commented

I've checked the current AccountAcitvityType enum values and see only one item that was missed - crypto fee mapping. The normal fee (FEE value in requests/responses) should be mapped to the AccountActivityType.RefTafFee (not the best name but I'm unable to change it immediately without breaking code for many users) member.

Originally posted by @OlegRa in #610 (comment)

  • Add the new members CryptoFee and FeeInUsd and map them to CFEE and FEE values respectively
  • Mark the existing RefTafFee member as obsolete and provide non-valid JSON mapping for it.
  • Update the extension method for getting paginated data and copy all original request fields.